Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Denormalize namespace name to job table #934

Closed
wants to merge 4 commits into from
Closed

Denormalize namespace name to job table #934

wants to merge 4 commits into from

Conversation

henneberger
Copy link
Contributor

@henneberger henneberger commented Feb 9, 2021 •
edited
Loading

The namespace uuid column and constraint can be dropped, and a new constraint on namespace name can be added in the next release

@codecov
Copy link

codecov bot commented Feb 10, 2021 •
edited
Loading

Codecov Report

Merging #934 (9ad0b71) into main (cae2ef0) will decrease coverage by 0.30%.
The diff coverage is 68.26%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #934      +/-   ##
============================================
- Coverage     72.88%   72.57%   -0.31%     
- Complexity      437      834     +397     
============================================
  Files           112      167      +55     
  Lines          2054     3770    +1716     
  Branches        188      355     +167     
============================================
+ Hits           1497     2736    +1239     
- Misses          269      568     +299     
- Partials        288      466     +178
Impacted Files Coverage Δ Complexity Δ
api/src/main/java/marquez/MarquezException.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...src/main/java/marquez/MarquezRuntimeException.java 0.00% <ø> (ø) 0.00 <0.00> (?)
api/src/main/java/marquez/api/JobResource.java 84.90% <ø> (ø) 18.00 <0.00> (?)
...i/src/main/java/marquez/api/NamespaceResource.java 90.00% <ø> (ø) 5.00 <0.00> (?)
api/src/main/java/marquez/api/RunResource.java 92.30% <ø> (ø) 7.00 <0.00> (?)
api/src/main/java/marquez/api/SourceResource.java 88.88% <ø> (ø) 4.00 <0.00> (?)
api/src/main/java/marquez/api/TagResource.java 80.00% <ø> (ø) 2.00 <0.00> (?)
...rquez/api/exceptions/DatasetNotFoundException.java 100.00% <ø> (ø) 1.00 <0.00> (?)
...pi/exceptions/DatasetVersionNotFoundException.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...marquez/api/exceptions/FieldNotFoundException.java 100.00% <ø> (ø) 1.00 <0.00> (?)
... and 185 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87b1031...9ad0b71. Read the comment docs.

wslulciuc
wslulciuc reviewed Feb 10, 2021
View reviewed changes
api/src/main/resources/marquez/db/migration/V20__alter_jobs_to_add_namespace_name.sql
@@ -0,0 +1,2 @@
ALTER TABLE jobs ADD namespace_name VARCHAR(255);
Copy link
Member

@wslulciuc wslulciuc Feb 10, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With PR #935 now merged, mind updating the migration version to V22 to maintain ordering?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr #935 was branched off of this commit so this pr can be closed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

wslulciuc
wslulciuc requested changes Feb 10, 2021
View reviewed changes
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 But, we'll need to update the migration version to V22 to maintain ordering.

@wslulciuc wslulciuc deleted the feature/job_namespace_name branch February 10, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wslulciuc wslulciuc wslulciuc requested changes

@julienledem julienledem julienledem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henneberger @julienledem @wslulciuc